f8fe517d12
We were caching the ConstExprValue of string literals, which works if you can never modify ConstExprValues. This premise is broken with `comptime var ...`. So I implemented an optimization in ConstExprValue arrays, where it stores a `Buf *` directly rather than an array of ConstExprValues for the elements, and then similar to array of undefined, it is expanded into the canonical form when necessary. However many operations can happen directly on the `Buf *`, which is faster. Furthermore, before a ConstExprValue array is expanded into canonical form, it removes itself from the string literal cache. This fixes the issue, because before an array element is modified it would have to be expanded. closes #1076
17 lines
388 B
Zig
17 lines
388 B
Zig
const std = @import("std");
|
|
const mem = std.mem;
|
|
const assert = std.debug.assert;
|
|
|
|
test "comptime code should not modify constant data" {
|
|
testCastPtrOfArrayToSliceAndPtr();
|
|
comptime testCastPtrOfArrayToSliceAndPtr();
|
|
}
|
|
|
|
fn testCastPtrOfArrayToSliceAndPtr() void {
|
|
var array = "aoeu";
|
|
const x: [*]u8 = &array;
|
|
x[0] += 1;
|
|
assert(mem.eql(u8, array[0..], "boeu"));
|
|
}
|
|
|