gitback/zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix uninitialized ZigValue

Browse Source
This commit is contained in:
xackus 2020-04-19 05:23:14 +02:00 committed by Andrew Kelley
parent 6c907a3509
commit d415ffd7d9
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/all_types.hpp
View File

@ -524,10 +524,11 @@ struct ZigValue {
RuntimeHintSlice rh_slice;
} data;
// uncomment these to find bugs. can't leave them uncommented because of a gcc-9 warning
//ZigValue(const ZigValue &other) = delete; // plz zero initialize with {}
// uncomment this to find bugs. can't leave it uncommented because of a gcc-9 warning
//ZigValue& operator= (const ZigValue &other) = delete; // use copy_const_val
ZigValue(const ZigValue &other) = delete; // plz zero initialize with ZigValue val = {};
// for use in debuggers
void dump();
};

2
src/ir.cpp
View File

@ -17009,7 +17009,7 @@ static IrInstGen *ir_analyze_bit_shift(IrAnalyze *ira, IrInstSrcBinOp *bin_op_in
if (op2_val == nullptr)
return ira->codegen->invalid_inst_gen;
ZigValue bit_count_value;
ZigValue bit_count_value = {};
init_const_usize(ira->codegen, &bit_count_value, bit_count);
if (!value_cmp_numeric_val_all(op2_val, CmpLT, &bit_count_value)) {