From 328eb8ed8dfdc646df28f899267c76e18645da40 Mon Sep 17 00:00:00 2001 From: LemonBoy Date: Sun, 19 Apr 2020 11:38:42 +0200 Subject: [PATCH] stage1: Fix signed multiplication overflow Spotted thanks to UBSan --- src/glibc.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glibc.cpp b/src/glibc.cpp index b78e140e1..2456cab44 100644 --- a/src/glibc.cpp +++ b/src/glibc.cpp @@ -362,9 +362,9 @@ Error glibc_build_dummies_and_maps(CodeGen *g, const ZigGLibCAbi *glibc_abi, con } uint32_t hash_glibc_target(const ZigTarget *x) { - return x->arch * 3250106448 + - x->os * 542534372 + - x->abi * 59162639; + return x->arch * (uint32_t)3250106448 + + x->os * (uint32_t)542534372 + + x->abi * (uint32_t)59162639; } bool eql_glibc_target(const ZigTarget *a, const ZigTarget *b) {