github method, as a derived method, should build a final repository URL
and let parent's respective methods do the actual work.
Register new 'el-get-github-pull function as update method.
Make both methods, 'el-get-github-pull and 'el-get-github-clone,
implement the same pattern:
- Delegate check if URL is a secure one to the parent method
- Ignore :url from package's recipe passed by 'el-get-do-update as it
makes no sense
- Unconditionally build package repository URL with 'el-get-github-url
- Call respective git method
In Emacs 25.1, a failed cl-assert will always jump to the debugger if
debug-on-error is non-nil. In batch-mode runs this becomes confusing
with the message suppression we have, and the crazy long stack traces
that are printed are really hard to read, so suppress this debugger
behaviour with advice as well.
A couple of recipes that were failing the test snuck in while the test
was accidentally disabled.
* .travis.yml (script):
* test/travis-ci.sh (prereqs): Remove folded_call; it was folding too
much, which made the logs needlessly difficult to read.
* recipes/flycheck-package.rcp (flycheck-package):
* recipes/idle-require.rcp (idle-require): Add :description field.
URL starting with 'file:///' (hostname is empty) is secure because it
always points to a local file.
OTOH, 'file://example.com/' (with any hostname, including 'localhost'
and '127.0.0.1') is insecure as it may refer to the remote file and
deciding if some hostname is actually a local in given moment in time is
tricky and too error-prone.
...because not a package itself but a URL user trying to install it from
is actually insecure. Mention URL in the error message like
Attempting to install package ag from insecure URL user@ftp://example.com/ without `el-get-allow-insecure
for easier troubleshooting.
There is now an additional package ivy-bibtex in the
tmalbsburg/helm-bibtex repository (and on MELPA). Helm-bibtex.el and ivy-bibtex.el are now two alternative
backends for the backend-independent bibtex-completion.el. The former
backend depends on helm whereas the latter depends on ivy (swiper).
So I updated the helm-bibtex and added the ivy-bibtex recipes, using the current
descriptions and dependencies.
Note that ideally, one should exclude the helm-bibtex.el file from the
ivy-bibtex package and the ivy-bibtex.el file from the helm-bibtex
package (as is done on MELPA). But I didn't find how to do this with el-get.
