gitback/doomemacs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e49b4a8123
doomemacs/modules/tools/gist/config.el

29 lines
924 B
EmacsLisp
Raw Normal View History

Major optimization refactor, across the board + enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster startup; ~5-20% general boost + reduce consing, function calls & garbage collection by preferring cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and various cl-lib filter/map/reduce functions) -- where possible + prefer functions with dedicated opcodes, like assq (see byte-defop's in bytecomp.el for more) + prefer pcase & cond (faster) over cl-case + general refactor for code readability + ensure naming & style conventions are adhered to + appease byte-compiler by marking unused variables with underscore + defer minor mode activation to after-init, emacs-startup or window-setup hooks; a customization opportunity for users + ensures custom functionality won't interfere with startup.
2017-06-08 17:47:56 +08:00
;;; tools/gist/config.el -*- lexical-binding: t; -*-
Add tools/gist
2017-05-07 21:10:46 +08:00
;; NOTE On occasion, the cache gets corrupted, causing wrong-type-argument
;; errors. If that happens, try `+gist/kill-cache'. You may have to restart
;; Emacs.
Major refactor & optimization of how modules load their packages Now that we are loading package autoloads files (as part of the generated doom-package-autoload-file when running make autoloads), many :commands properties are redundant. In fact, many def-package! blocks are redundant. In some cases, we can do without a config.el file entirely, and can move into the autoloads file or rely entirely on package autoloads. Also, many settings have been moved in their module's autoloads files, which makes them available ASAP; their use no longer depends on module load order. This gained me a modest ~10% boost in startup speed.
2018-05-25 06:46:11 +08:00
(after! gist
Introduce autodefs to replace some settings + :popup -> set-popup-rule! + :popups -> set-popup-rules! + :company-backend -> set-company-backend! + :evil-state -> set-evil-initial-state! I am slowly phasing out the setting system (def-setting! and set!), starting with these. What are autodefs? These are functions that are always defined, whether or not their respective modules are enabled. However, when their modules are disabled, they are replaced with macros that no-op and don't waste time evaluating their arguments. The old set! function will still work, for a while.
2018-06-15 08:58:12 +08:00
(set-evil-initial-state! 'gist-list-mode 'normal)
Add tools/gist
2017-05-07 21:10:46 +08:00
tools/gist: open gists in non-popups - Removes +gist/kill-cache (gist-list and gist-list-user with a universal argument already does this). - Removes +gist/open-current. No longer necessary when gists aren't opened in popups. - Makes keybinds more consistent with other "porcelains", like elfeed's or magit.
2019-04-03 00:50:18 +08:00
(set-popup-rule! "^\\*gist-" :ignore t)
def-advice!->defadvice! & conform to new advice conventions This commit does two things: - Renames def-advice! to defadvice!, in the spirit of naming convenience macros after the function/macro they enhance or replace. - Correct the names of advice functions to indicate visibility and intent. A public advice function like doom-set-jump-a is meant to be used elsewhere. A private one like +dired--cleanup-header-line-a shouldn't -- it likely won't work anywhere but the function(s) it was made to advise.
2019-07-23 23:24:56 +08:00
(defadvice! +gist--open-in-popup-a (orig-fn &rest args)
tools/gist: conform to new conventions
2019-07-23 05:35:25 +08:00
:around #'gist-list-render
Major optimization refactor, across the board + enable lexical-scope everywhere (lexical-binding = t): ~5-10% faster startup; ~5-20% general boost + reduce consing, function calls & garbage collection by preferring cl-loop & dolist over lambda closures (for mapc[ar], add-hook, and various cl-lib filter/map/reduce functions) -- where possible + prefer functions with dedicated opcodes, like assq (see byte-defop's in bytecomp.el for more) + prefer pcase & cond (faster) over cl-case + general refactor for code readability + ensure naming & style conventions are adhered to + appease byte-compiler by marking unused variables with underscore + defer minor mode activation to after-init, emacs-startup or window-setup hooks; a customization opportunity for users + ensures custom functionality won't interfere with startup.
2017-06-08 17:47:56 +08:00
(funcall orig-fn (car args) t)
(unless (cadr args)
Move evil & corrective keybinds to respective modules Keybinds that correct behavior or provide or extend vim functionality were moved to their respective modules, or to the :editor evil module. Keybinds in the global space, that are particularly opinionated but potentially harmful or imposing as a default, or likely for users to change (like leader keys), are kept in config/default.
2019-10-27 09:34:44 +08:00
(pop-to-buffer (current-buffer))))
(map! :map gist-list-menu-mode-map
:n "go" #'gist-browse-current-url
:n "gr" #'gist-list-reload
:n "c" #'gist-add-buffer
:n "d" #'gist-kill-current
:n "e" #'gist-edit-current-description
:n "f" #'gist-fork
:n "q" #'kill-current-buffer
:n "s" #'gist-star
:n "S" #'gist-unstar
:n "y" #'gist-print-current-url))
Reference in New Issue Copy Permalink